[WIP] Removed the OutBHandler and MemAccessHandler abstractions and related implementations. #732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simongdavies
added
the
kind/enhancement
simongdavies
requested review from
danbugs,
ludfjig,
dblnz,
devigned,
syntactically,
marosset and
jprendes
as code owners
… implementations. Signed-off-by: Simon Davies <[email protected]>
simongdavies
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #495
This pull request refactors the handling of virtual CPU (vCPU) operations in the Hyperlight hypervisor, focusing on simplifying memory management and removing outdated abstractions. The changes primarily affect the Linux and Windows implementations of the hypervisor, introducing a new memory manager (
MemMgrWrapper) and function registry (FunctionRegistry) while eliminating theOutBHandlerandMemAccessHandlerabstractions.Removal of Outdated Abstractions:
OutBHandlerandMemAccessHandlertraits and their associated types (OutBHandlerWrapper,MemAccessHandlerWrapper, etc.) fromsrc/hyperlight_host/src/hypervisor/handlers.rsas they are no longer needed. [1] [2]Introduction of New Memory Management:
mem_mgr(type:MemMgrWrapper<HostSharedMemory>) andhost_funcs(type:Arc<Mutex<FunctionRegistry>>) to theHypervLinuxDriverandHypervWindowsDriverstructs for centralized memory and function handling. [1] [2]Refactoring of Hypervisor Logic:
Hypervisortrait implementations for both Linux and Windows drivers to use the newmem_mgrandhost_funcsfields instead of the removed handler abstractions. This includes changes to methods likeinitialize,dispatch_call_from_host, andhandle_outb. [1] [2] [3] [4]