Skip to content

Enable debugging on windows #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Enable debugging on windows #478

wants to merge 3 commits into from

Conversation

dblnz
Copy link
Contributor

@dblnz dblnz commented May 9, 2025 •
edited
Loading

Description

This closes #241

This brings the same debugging behavior to windows guests as kvm and mshv guests have on linux with the following caveat:

  • does not support gdb client signals to guests. To enable this we need to find a way to send a signal to the guest vCPU or make it exit. This needs to be sent from the gdb thread in which we do not have a handle to the processor.

Some of the duplicated debug logic that is implemented on each hypervisor driver will be refactored later in a single implementation.

@dblnz dblnz added the kind/enhancement For PRs adding features, improving functionality, docs, tests, etc. label May 9, 2025
@ludfjig
Copy link
Contributor

ludfjig commented May 15, 2025

Nice. Any chance we could land this after #469? :P

@dblnz
Copy link
Contributor Author

dblnz commented May 17, 2025

Yes, I was thinking on doing that to be less work for solving conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danbugs danbugs Awaiting requested review from danbugs danbugs will be requested when the pull request is marked ready for review danbugs is a code owner

@ludfjig ludfjig Awaiting requested review from ludfjig ludfjig will be requested when the pull request is marked ready for review ludfjig is a code owner

@devigned devigned Awaiting requested review from devigned devigned will be requested when the pull request is marked ready for review devigned is a code owner

@syntactically syntactically Awaiting requested review from syntactically syntactically will be requested when the pull request is marked ready for review syntactically is a code owner

@marosset marosset Awaiting requested review from marosset marosset will be requested when the pull request is marked ready for review marosset is a code owner

@jprendes jprendes Awaiting requested review from jprendes jprendes will be requested when the pull request is marked ready for review jprendes is a code owner

@simongdavies simongdavies Awaiting requested review from simongdavies simongdavies will be requested when the pull request is marked ready for review simongdavies is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
kind/enhancement For PRs adding features, improving functionality, docs, tests, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support debugging Hyperlight on Windows
2 participants
@dblnz @ludfjig