Add error messages for contradicting flags #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Svetoslav Blyahov <[email protected]>
EnriqueL8
reviewed
Nov 6, 2024
cmd/init.go
Outdated
| @@ -260,6 +268,20 @@ func validatePrivateTransactionManagerBlockchainConnectorCombination(privateTran | |||
| return nil | |||
| } | |||
|
|
|||
| func validateRemoteNodeVsBlockChainNodeFlags(remoteNodeUrl, blockchainNodePorvider string) error { | |||
| if len(remoteNodeUrl) != 0 && blockchainNodePorvider != "geth" { | |||
| return errors.New("`remote-noted-url` and `blockchain-node` can't both be specified") | |||
There was a problem hiding this comment.
Suggested change
| return errors.New("`remote-noted-url` and `blockchain-node` can't both be specified") | |
| return errors.New("Both flags `remote-node-url` and `blockchain-node` can't be specified") |
There was a problem hiding this comment.
hi @EnriqueL8, thanks for your review. I will correct the text and look for a place where to place the test.
There was a problem hiding this comment.
hi @EnriqueL8, now that I took a deeper look, I remembered why I didn't provide tests initially. I didn't find any of the initCommon behavior to have been tested. Can you please let me know if I'm mistaken, or if not - and still a test needs to be written for this part - where, according to the practices of this repo, shall it be?
Thanks in advance for your help.
There was a problem hiding this comment.
okay this might be more significant work to establish a test framework for these
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to fix the issue mentioned here #290