Merge pull request #257 from berendsliedrecht/ignore-npmrc-and-so-files

do not write to .npmrc for release
hyperledger · Oct 26, 2023 · a3e5a86 · a3e5a86
2 parents f0a7d2f + 6939c93
commit a3e5a86
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 9 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -208,6 +208,7 @@ jobs:
         uses: actions/setup-node@v3
         with:
           node-version: 18.x
+          registry-url: "https://registry.npmjs.org/"
 
       - uses: pnpm/action-setup@v2
         with:
@@ -239,20 +240,14 @@ jobs:
           LIB_ANONCREDS_PATH: ../../
         run: pnpm test
 
-      - name: Set NPM config
-        if: |
-          github.event_name == 'release' ||
-          (github.event_name == 'workflow_dispatch' && github.event.inputs.publish-wrappers == 'true')
-        run: |
-          echo "//registry.npmjs.org/:_authToken=${{ secrets.NPM_TOKEN }}" >> .npmrc
-          echo "registry=https://registry.npmjs.org/" >> .npmrc
-          echo "always-auth=true" >> .npmrc
-
       - name: Publish JavaScript Wrapper
         if: |
           github.event_name == 'release' ||
           (github.event_name == 'workflow_dispatch' && github.event.inputs.publish-wrappers == 'true')
         run: npx lerna publish from-package --no-push --no-private --yes --no-git-tag-version
+        env:
+          NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
+
 
   build-py:
     name: Build Python

diff --git a/.gitignore b/.gitignore
@@ -4,4 +4,5 @@ out
 Cargo.lock
 .DS_Store
 .tmp
+*.so
 *.tgz