Skip to content

Add troubleshooting guide for bundling issues #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

anhlh-edsolabs
Copy link
Contributor

@anhlh-edsolabs anhlh-edsolabs commented Jun 4, 2025

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

This pull request includes updates that address and resolve issue #425.

@anhlh-edsolabs anhlh-edsolabs changed the title Add troubleshooting guide for bundling issues (#425) Add troubleshooting guide for bundling issues Jun 4, 2025
@isegall-da
Copy link
Contributor

@anhlh-edsolabs You're missing a couple of things to get this mergeable:

@anhlh-edsolabs
Copy link
Contributor Author

@isegall-da Thanks. I have updated the PR as instructed.

@anhlh-edsolabs anhlh-edsolabs force-pushed the anhle/425-add-troubleshooting-guide branch from 5df62b3 to 8866004 Compare June 6, 2025 03:32
@anhlh-edsolabs
Copy link
Contributor Author

@isegall-da can you check if this PR is good to go? Thanks!

@isegall-da
Copy link
Contributor

Seems fine, but apparently we broke CI on forks. I'll need to fix that for this to be mergable, looking into that now.

@isegall-da
Copy link
Contributor

@anhlh-edsolabs CI should be fixed on main now, can you please rebase on Splice main so that we can get this past CI?

@anhlh-edsolabs
Copy link
Contributor Author

@isegall-da The branch has been rebased on Splice main. I think it still need your review.

@isegall-da
Copy link
Contributor

Thanks. Approved CI now

@isegall-da
Copy link
Contributor

@anhlh-edsolabs sorry, can you please push another empty [static] commit (or amend the merge commit to add [static] to its comment) ?

Signed-off-by: Le Hoang Anh <[email protected]>
@anhlh-edsolabs
Copy link
Contributor Author

@isegall-da Hi, [static] commit added 😉

Copy link
Contributor

@moritzkiefer-da moritzkiefer-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks!

@moritzkiefer-da moritzkiefer-da merged commit 0e87db4 into hyperledger-labs:main Jun 12, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants