add destination rules for sequencer high performance gRPC #3402
+194
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[static] Signed-off-by: Mateusz Błażejewski <[email protected]>
| return [ | ||
| ...(function* () { | ||
| for (const migration of DecentralizedSynchronizerUpgradeConfig.runningMigrations()) { | ||
| for (const sv of coreSvsToDeploy) { |
Contributor
There was a problem hiding this comment.
Why not allSvsToDeploy? I guess it doesn't matter for MainNet (only core SVs there), but for consistency?
| namespace: ingressNs.metadata.name, | ||
| }, | ||
| spec: { | ||
| host: `${sequencerName}.${ingressName}.svc.cluster.local`, |
Contributor
There was a problem hiding this comment.
To be clear: The intention here is to use k8s-internal addresses, not the external one we define via VirtualService?
If so... can't you just check on a scratchnet cluster or CILR if you got the hostname right? I'd launch a shell on some validator pod and try reaching the endpoint from there via curl or grpcurl.
(Not very confident about the networking stuff here myself...)
[static] Signed-off-by: Mateusz Błażejewski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/DACH-NY/canton-network-internal/issues/2791
I am not very confident about these changes. I had some difficulties figuring out the sequencer hostname and I'm still not 100% sure I got it right. I'm also not sure if my assumptions about how to iterate through SVs and migrations are correct.