-
Notifications
You must be signed in to change notification settings - Fork 53
update tokenomics #3355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
update tokenomics #3355
Conversation
Signed-off-by: hrischuk-da <[email protected]>
test-cometbft-full-class-names.log
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you meant to delete any of these...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@isegall-da I thought the log files were a side effect of my building the docs. Are you suggesting that we are checking in the log files and they shouldn't be deleted? If so, out of curiosity, what is the value of those log files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are not log files (despite their ending). They define the split of tests for their parallel execution across multiple CI machines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are produced by logging particular sbt output. That's the reason for the ending.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe I've added the log files back in the latest commit. Appreciate it if someone can confirm and approve.
Co-authored-by: Itai Segall <[email protected]> Signed-off-by: hrischuk-da <[email protected]>
meiersi-da
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx. I see @isegall-da also reviewed and requested changes. I'll leave the final approval to him.
Co-authored-by: Itai Segall <[email protected]> Signed-off-by: hrischuk-da <[email protected]>
Co-authored-by: Itai Segall <[email protected]> Signed-off-by: hrischuk-da <[email protected]>
Co-authored-by: Simon Meier <[email protected]> Signed-off-by: hrischuk-da <[email protected]>
Signed-off-by: hrischuk-da <[email protected]>
meiersi-da
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @hrischuk-da 🙏
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines