-
Notifications
You must be signed in to change notification settings - Fork 18
Add ans-web-ui for app-user and app-provider. … #1071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ans-web-ui for app-user and app-provider. … #1071
Conversation
…[ci] Signed-off-by: Peter Kvokacka <[email protected]>
cluster/compose/localnet/README.md
Outdated
@@ -23,8 +23,6 @@ Additional environment variables include: | |||
- **LOCALNET_DIR/compose.env**: Contains Docker Compose configuration variables. | |||
- **LOCALNET_ENV_DIR/common.env**: Shared environment variables across Docker Compose and container configurations. It sets default ports, DB credentials, and Splice UI configurations. | |||
|
|||
Depending on the desired environment **ENV** (local or dev), either `LOCALNET_ENV_DIR/dev.env` or `LOCALNET_ENV_DIR/local.env` will be applied to both Docker Compose and Splice containers, with `local` set as the default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused, in slack we discussed to keep it, why are you removing it now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discussed it further with etx team. Work was already done (in both splice and QS) and we decided to proceed with removal. Are you ok with that? I makes Splice LocalNet cleaner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm if Curtis wants to keep devnet support in QS I'd lean towards also keeping it here.
In the end if app devs do want this, we have plenty of app devs that just use localnet but don't care about all of QS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peterkvokacka-da let's not make this change.
Here is a very simple diagnostic use case that I've used 10s of times because DevNet can have challenges.
- Try to run my app on DevNet to incorporate all the delays that occur in a Gsync. The app fails mysteriously.
- Switch back to LocalNet and run my app. It passes.
- Go get a coffee and wait for DevNet to become more stable.
Even if DevNet is super stable, I forsee that the different behaviro between LocalNet and DevNet still require dev testing on both.
So, let's wait for feedback that provides some signal to remove the ability to run on DevNet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hrischuk-da this is not a question about access to devnet - it's a matter of whether that support is built into Splice Localnet, or QS. The scenario you outline is not in question with QS, only with those using raw Splice Localnet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok I removed the removal of devnet support from the PR.
Signed-off-by: Peter Kvokacka <[email protected]>
Signed-off-by: Peter Kvokacka <[email protected]>
Signed-off-by: Peter Kvokacka <[email protected]>
cluster/compose/localnet/README.md
Outdated
- **VALIDATOR_ADMIN_API_PORT**: 5003 | ||
- **CANTON_HTTP_HEALTHCHECK_PORT**: 7000 | ||
- **CANTON_GRPC_HEALTHCHECK_PORT**: 5061 | ||
- **PARTICIPANT_LEDGER_API_PORT**: 901 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks problematic to me. Ports up to 1024 require root on Linux. I don't think we should use this for localnet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
those are just "base" ports never used directly. always combined with env prefix e.g.
2${PARTICIPANT_LEDGER_API_PORT} for app user
3${PARTICIPANT_LEDGER_API_PORT} for app provider
4${PARTICIPANT_LEDGER_API_PORT} for sv
cluster/compose/localnet/README.md
Outdated
- **PARTICIPANT_ADMIN_API_PORT**: 902 | ||
- **PARTICIPANT_JSON_API_PORT**: 975 | ||
- **VALIDATOR_ADMIN_API_PORT**: 903 | ||
- **CANTON_HTTP_HEALTHCHECK_PORT**: 900 | ||
- **CANTON_GRPC_HEALTHCHECK_PORT**: 961 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- **PARTICIPANT_ADMIN_API_PORT**: 902 | |
- **PARTICIPANT_JSON_API_PORT**: 975 | |
- **VALIDATOR_ADMIN_API_PORT**: 903 | |
- **CANTON_HTTP_HEALTHCHECK_PORT**: 900 | |
- **CANTON_GRPC_HEALTHCHECK_PORT**: 961 | |
- **PARTICIPANT_LEDGER_API_PORT**: X901 | |
- **PARTICIPANT_ADMIN_API_PORT**: X902 | |
- **PARTICIPANT_JSON_API_PORT**: X975 | |
- **VALIDATOR_ADMIN_API_PORT**: X903 | |
- **CANTON_HTTP_HEALTHCHECK_PORT**: X900 | |
- **CANTON_GRPC_HEALTHCHECK_PORT**: X961 |
cluster/compose/localnet/README.md
Outdated
@@ -39,12 +39,12 @@ Other ports follow a specific pattern based on the validator: | |||
- `2${PORT}`: App User port | |||
|
|||
These patterns apply to the following ports: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These patterns apply to the following ports: | |
These patterns apply to the following ports where X is 2, 3 or 4 as described above: |
VALIDATOR_ADMIN_API_PORT=${VALIDATOR_ADMIN_API_PORT:-5003} | ||
CANTON_HTTP_HEALTHCHECK_PORT=${CANTON_HTTP_HEALTHCHECK_PORT:-7000} | ||
CANTON_GRPC_HEALTHCHECK_PORT=${CANTON_GRPC_HEALTHCHECK_PORT:-5061} | ||
PARTICIPANT_LEDGER_API_PORT=${PARTICIPANT_LEDGER_API_PORT:-901} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's rename this to port suffix or something like that. Otherwise it's super confusing that this is not the actual port that ends up being used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Signed-off-by: Peter Kvokacka <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
…net-support-from-splice-localnet
Signed-off-by: Peter Kvokacka <[email protected]>
…net-support-from-splice-localnet
Signed-off-by: Peter Kvokacka <[email protected]>
a91c38d
into
hyperledger-labs:main
… [ci]
also changing base ports. New calculated ports will be outside of OS's dynamic port range in order to prevent port bindings problem like this:
Pull Request Checklist
Cluster Testing
/cluster_test
on this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_test
on this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n
, and mention issues worked on using#n
Merge Guidelines