Skip to content

Add ans-web-ui for app-user and app-provider. … #1071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

peterkvokacka-da
Copy link
Contributor

@peterkvokacka-da peterkvokacka-da commented Jun 11, 2025

… [ci]
also changing base ports. New calculated ports will be outside of OS's dynamic port range in order to prevent port bindings problem like this:

Failed to bind to address /0.0.0.0:35002

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

@@ -23,8 +23,6 @@ Additional environment variables include:
- **LOCALNET_DIR/compose.env**: Contains Docker Compose configuration variables.
- **LOCALNET_ENV_DIR/common.env**: Shared environment variables across Docker Compose and container configurations. It sets default ports, DB credentials, and Splice UI configurations.

Depending on the desired environment **ENV** (local or dev), either `LOCALNET_ENV_DIR/dev.env` or `LOCALNET_ENV_DIR/local.env` will be applied to both Docker Compose and Splice containers, with `local` set as the default.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused, in slack we discussed to keep it, why are you removing it now.

Copy link
Contributor Author

@peterkvokacka-da peterkvokacka-da Jun 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed it further with etx team. Work was already done (in both splice and QS) and we decided to proceed with removal. Are you ok with that? I makes Splice LocalNet cleaner.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm if Curtis wants to keep devnet support in QS I'd lean towards also keeping it here.

In the end if app devs do want this, we have plenty of app devs that just use localnet but don't care about all of QS.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peterkvokacka-da let's not make this change.

Here is a very simple diagnostic use case that I've used 10s of times because DevNet can have challenges.

  1. Try to run my app on DevNet to incorporate all the delays that occur in a Gsync. The app fails mysteriously.
  2. Switch back to LocalNet and run my app. It passes.
  3. Go get a coffee and wait for DevNet to become more stable.

Even if DevNet is super stable, I forsee that the different behaviro between LocalNet and DevNet still require dev testing on both.

So, let's wait for feedback that provides some signal to remove the ability to run on DevNet.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hrischuk-da this is not a question about access to devnet - it's a matter of whether that support is built into Splice Localnet, or QS. The scenario you outline is not in question with QS, only with those using raw Splice Localnet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok I removed the removal of devnet support from the PR.

@peterkvokacka-da peterkvokacka-da changed the title Remove devnet support. Add ans-web-ui for app-user and app-provider. … Add ans-web-ui for app-user and app-provider. … Jun 11, 2025
@github-actions github-actions bot added the fork label Jun 11, 2025
Signed-off-by: Peter Kvokacka <[email protected]>
- **VALIDATOR_ADMIN_API_PORT**: 5003
- **CANTON_HTTP_HEALTHCHECK_PORT**: 7000
- **CANTON_GRPC_HEALTHCHECK_PORT**: 5061
- **PARTICIPANT_LEDGER_API_PORT**: 901
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks problematic to me. Ports up to 1024 require root on Linux. I don't think we should use this for localnet.

Copy link
Contributor Author

@peterkvokacka-da peterkvokacka-da Jun 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those are just "base" ports never used directly. always combined with env prefix e.g.

2${PARTICIPANT_LEDGER_API_PORT} for app user
3${PARTICIPANT_LEDGER_API_PORT} for app provider
4${PARTICIPANT_LEDGER_API_PORT} for sv

documented here https://github.com/peterkvokacka-da/splice/blob/peterkvokacka-da/remove-devnet-support-from-splice-localnet/cluster/compose/localnet/README.md#exposed-ports

Comment on lines 43 to 47
- **PARTICIPANT_ADMIN_API_PORT**: 902
- **PARTICIPANT_JSON_API_PORT**: 975
- **VALIDATOR_ADMIN_API_PORT**: 903
- **CANTON_HTTP_HEALTHCHECK_PORT**: 900
- **CANTON_GRPC_HEALTHCHECK_PORT**: 961
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **PARTICIPANT_ADMIN_API_PORT**: 902
- **PARTICIPANT_JSON_API_PORT**: 975
- **VALIDATOR_ADMIN_API_PORT**: 903
- **CANTON_HTTP_HEALTHCHECK_PORT**: 900
- **CANTON_GRPC_HEALTHCHECK_PORT**: 961
- **PARTICIPANT_LEDGER_API_PORT**: X901
- **PARTICIPANT_ADMIN_API_PORT**: X902
- **PARTICIPANT_JSON_API_PORT**: X975
- **VALIDATOR_ADMIN_API_PORT**: X903
- **CANTON_HTTP_HEALTHCHECK_PORT**: X900
- **CANTON_GRPC_HEALTHCHECK_PORT**: X961

@@ -39,12 +39,12 @@ Other ports follow a specific pattern based on the validator:
- `2${PORT}`: App User port

These patterns apply to the following ports:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
These patterns apply to the following ports:
These patterns apply to the following ports where X is 2, 3 or 4 as described above:

VALIDATOR_ADMIN_API_PORT=${VALIDATOR_ADMIN_API_PORT:-5003}
CANTON_HTTP_HEALTHCHECK_PORT=${CANTON_HTTP_HEALTHCHECK_PORT:-7000}
CANTON_GRPC_HEALTHCHECK_PORT=${CANTON_GRPC_HEALTHCHECK_PORT:-5061}
PARTICIPANT_LEDGER_API_PORT=${PARTICIPANT_LEDGER_API_PORT:-901}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rename this to port suffix or something like that. Otherwise it's super confusing that this is not the actual port that ends up being used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

@moritzkiefer-da moritzkiefer-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@moritzkiefer-da moritzkiefer-da enabled auto-merge (squash) June 12, 2025 12:29
@moritzkiefer-da moritzkiefer-da self-assigned this Jun 12, 2025
Signed-off-by: Peter Kvokacka <[email protected]>
Signed-off-by: Peter Kvokacka <[email protected]>
@moritzkiefer-da moritzkiefer-da merged commit a91c38d into hyperledger-labs:main Jun 13, 2025
113 of 115 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants