Support running tests with an older initial package version set #1014

moritzkiefer-da · 2025-06-06T07:23:33Z

to catch missing Daml version guards

fixes #452

[ci]

Pull Request Checklist

Cluster Testing

If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

Include any change that might be observable by our partners or affect their deployment in the release notes.
Specify fixed issues with Fixes #n, and mention issues worked on using #n
Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

to catch missing Daml version guards fixes #452 [ci] Signed-off-by: Moritz Kiefer <[email protected]>

Signed-off-by: Moritz Kiefer <[email protected]>

[ci] Signed-off-by: Moritz Kiefer <[email protected]>

Signed-off-by: Moritz Kiefer <[email protected]>

…on-checks

[ci] Signed-off-by: Moritz Kiefer <[email protected]>

Signed-off-by: Moritz Kiefer <[email protected]>

moritzkiefer-da · 2025-06-11T11:19:51Z

.github/actions/tests/scala_test/action.yml

@@ -133,6 +136,35 @@ runs:
      with:
        cache_version: 4

+    - name: Set Daml package versions


This is not as precise as we probably should be: It relies on the version shipped to mainnet, not the versions vetted on mainnet. The latter is a bit of a mess since we also need a splitwell version which is not in the packageConfig, definitely solvable but annoying. So for now I'd suggest we keep it as is and open a separate issue for making the version we test against it more precise. This still gives us a two week compatibility window at a minimum which is much better than what we had so far.

moritzkiefer-da · 2025-06-11T11:31:28Z

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/util/AmuletConfigUtil.scala

-        .decentralizedSynchronizer
-        .activeSynchronizer
-    val domainFeesConfig = defaultSynchronizerFeesConfig
-    defaultAmuletConfig(


this was just buggy, this used the default config instead of the existing one.

moritzkiefer-da · 2025-06-11T11:31:35Z

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/util/ConfigScheduleUtil.scala

-      nextSynchronizerId = nextSynchronizerId,
+    val existingAmuletConfig = AmuletConfigSchedule(amuletRules)
+      .getConfigAsOf(env.environment.clock.now)
+    val existingTransferConfig = existingAmuletConfig.transferConfig


this was just buggy, this used the default config instead of the existing one.

moritzkiefer-da · 2025-06-11T11:31:45Z

.../main/scala/com/digitalasset/canton/admin/api/client/commands/ParticipantAdminCommands.scala

@@ -193,7 +193,7 @@ object ParticipantAdminCommands {
                if (dar.description.isEmpty)
                  PathUtils.getFilenameWithoutExtension(Path.of(filename))
                else dar.description
-              _ = logger.info(s"Sending upload doar for ${descriptionOrFilename}")(
+              _ = logger.info(s"Sending upload dar for ${descriptionOrFilename}")(


[ci] Signed-off-by: Moritz Kiefer <[email protected]>

moritzkiefer-da · 2025-06-11T11:33:51Z

...app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/SplitwellTestUtil.scala

+      "Sender accepts payment request",
+      senderWallet.acceptAppPaymentRequest(request.contractId),
+    )(
+      "Splitwell completes payment",


not sure this actually mattered in the end but it makes debugging easier at least to synchronize on this

[ci] Signed-off-by: Moritz Kiefer <[email protected]>

Signed-off-by: Moritz Kiefer <[email protected]>

…on-checks

[ci] Signed-off-by: Moritz Kiefer <[email protected]>

moritzkiefer-da · 2025-06-11T13:12:51Z

I had a green build on this and only changed the from triggering on the PR to triggering periodically in the last commit 0a13a13

moritzkiefer-da · 2025-06-12T06:17:01Z

@nicu-da @isegall-da could I get a review on this please

nicu-da

Really nice! Thank you!

nicu-da · 2025-06-12T07:50:11Z

.github/actions/tests/scala_test/action.yml

@@ -83,6 +83,9 @@ inputs:
  failure_notifications_slack_channel:
    description: "Slack channel for failure notifications (for failure notifications)"
    required: true
+  daml_base_version:


Nit: can we add a description as to what is this used? Makes easier compared to having to read the action

nicu-da · 2025-06-12T07:58:04Z

.../org/lfdecentralizedtrust/splice/integration/plugins/TokenStandardCliSanityCheckPlugin.scala

-            val participantHttpApiPort =
-              validator.participantClient.config.ledgerApi.port.unwrap + 1000
+        val sv1 = environment.svs.local.find(_.name == "sv1").value
+        val amuletVersion = inside(sv1.config.onboarding) {


Nit: any reason why we don't read the current vetted version from the topology state?

I find this a bit easier to debug. I had quite a few cases where a prior test messed up the vetting state by vetting too much but the next one ran with an older initial package config change or something like that. This isn't gonna fix it but at least it makes it easier to figure out what is going wrong™

nicu-da · 2025-06-12T08:04:08Z

...rg/lfdecentralizedtrust/splice/integration/tests/BootstrapPackageConfigIntegrationTest.scala

@@ -42,6 +42,7 @@ import java.time.Instant
 import java.time.temporal.ChronoUnit
 import scala.jdk.CollectionConverters.*

+@org.lfdecentralizedtrust.splice.util.scalatesttags.NoDamlCompatibilityCheck


I LOVE IT!

Can we adda readme on how to add new tags and when to use them? (can be done later in a different PR)

did you see the readme I added?

In DEVELOPMENT.md or something else that I'm missing?
I'm seeing there instructions to tag a test if it doesn't work with this setup but I don't see anything about how are tags used, when to add a new type of tag and how to make the test run aware of it.

nicu-da · 2025-06-12T08:08:40Z

scripts/initial-package-config.py

Can we add a comment as to what it does?

nicu-da · 2025-06-12T08:09:19Z

apps/common/src/test/scala/org/lfdecentralizedtrust/splice/util/ScalaTestTags.scala

+
+import org.scalatest.Tag
+
+object Tags {


Can we add a comment for each tag as to why they exist and when they're used?

…on-checks Signed-off-by: Moritz Kiefer <[email protected]>

[ci] Signed-off-by: Moritz Kiefer <[email protected]>

meiersi-da

Very nice work! Thank you @moritzkiefer-da .

[ci] Signed-off-by: Moritz Kiefer <[email protected]>

isegall-da · 2025-06-12T10:24:14Z

@nicu-da @isegall-da could I get a review on this please

Argh, why did I not get notified of the original review request?? 😠

moritzkiefer-da force-pushed the cocreature/daml-version-checks branch 7 times, most recently from 3b9e4eb to 35e20bd Compare June 6, 2025 12:32

Support running tests with an older initial package version set

33320a1

to catch missing Daml version guards fixes #452 [ci] Signed-off-by: Moritz Kiefer <[email protected]>

moritzkiefer-da force-pushed the cocreature/daml-version-checks branch from 35e20bd to 33320a1 Compare June 6, 2025 13:04

.

cc5f91a

Signed-off-by: Moritz Kiefer <[email protected]>

moritzkiefer-da force-pushed the cocreature/daml-version-checks branch from b2062dc to 99c18cd Compare June 10, 2025 08:08

.

33b8806

[ci] Signed-off-by: Moritz Kiefer <[email protected]>

moritzkiefer-da force-pushed the cocreature/daml-version-checks branch from 99c18cd to 33b8806 Compare June 10, 2025 08:19

cocreature added 6 commits June 10, 2025 08:46

.

978b9eb

Signed-off-by: Moritz Kiefer <[email protected]>

Merge remote-tracking branch 'origin/main' into cocreature/daml-versi…

b687d30

…on-checks

improve

ec7ca88

[ci] Signed-off-by: Moritz Kiefer <[email protected]>

more fixes

df5b9ec

[ci] Signed-off-by: Moritz Kiefer <[email protected]>

how about some more fixes

fbda1fb

[ci] Signed-off-by: Moritz Kiefer <[email protected]>

fixe

05e4b5d

[ci] Signed-off-by: Moritz Kiefer <[email protected]>

moritzkiefer-da force-pushed the cocreature/daml-version-checks branch from abcd3b4 to 05e4b5d Compare June 10, 2025 10:50

cocreature added 5 commits June 10, 2025 11:29

and more test fixes

20ba7e1

[ci] Signed-off-by: Moritz Kiefer <[email protected]>

.

6fe06f9

[ci] Signed-off-by: Moritz Kiefer <[email protected]>

.

ae2adc4

[ci] Signed-off-by: Moritz Kiefer <[email protected]>

.

a6d23aa

[ci] Signed-off-by: Moritz Kiefer <[email protected]>

.

706a970

[ci] Signed-off-by: Moritz Kiefer <[email protected]>

moritzkiefer-da force-pushed the cocreature/daml-version-checks branch 2 times, most recently from c860011 to a0d6d98 Compare June 10, 2025 14:09

.

25b195f

[ci] Signed-off-by: Moritz Kiefer <[email protected]>

moritzkiefer-da force-pushed the cocreature/daml-version-checks branch from a0d6d98 to 25b195f Compare June 10, 2025 14:13

.

6b3c397

[ci] Signed-off-by: Moritz Kiefer <[email protected]>

moritzkiefer-da force-pushed the cocreature/daml-version-checks branch from 918cbda to cf888cd Compare June 11, 2025 11:00

.

77089ed

[ci] Signed-off-by: Moritz Kiefer <[email protected]>

moritzkiefer-da force-pushed the cocreature/daml-version-checks branch from cf888cd to 77089ed Compare June 11, 2025 11:06

.

98e66f8

Signed-off-by: Moritz Kiefer <[email protected]>

moritzkiefer-da commented Jun 11, 2025

View reviewed changes

.

e9eeaaf

[ci] Signed-off-by: Moritz Kiefer <[email protected]>

moritzkiefer-da force-pushed the cocreature/daml-version-checks branch from a57e800 to e9eeaaf Compare June 11, 2025 11:32

moritzkiefer-da commented Jun 11, 2025

View reviewed changes

add header

331aad0

[ci] Signed-off-by: Moritz Kiefer <[email protected]>

moritzkiefer-da force-pushed the cocreature/daml-version-checks branch from 2ff0d50 to 331aad0 Compare June 11, 2025 12:12

cocreature added 3 commits June 11, 2025 12:56

upgrade canton binary

4a1d614

Signed-off-by: Moritz Kiefer <[email protected]>

Merge remote-tracking branch 'origin/main' into cocreature/daml-versi…

4dd30cd

…on-checks

switch to cron

0a13a13

[ci] Signed-off-by: Moritz Kiefer <[email protected]>

moritzkiefer-da requested a review from nicu-da June 11, 2025 13:13

moritzkiefer-da marked this pull request as ready for review June 11, 2025 13:13

moritzkiefer-da requested a review from isegall-da June 11, 2025 13:14

nicu-da approved these changes Jun 12, 2025

View reviewed changes

cocreature added 2 commits June 12, 2025 08:19

Merge remote-tracking branch 'origin/main' into cocreature/daml-versi…

5136654

…on-checks Signed-off-by: Moritz Kiefer <[email protected]>

review

ef3a7b8

[ci] Signed-off-by: Moritz Kiefer <[email protected]>

meiersi-da reviewed Jun 12, 2025

View reviewed changes

cocreature added 2 commits June 12, 2025 08:35

readme

83fd8b4

[ci] Signed-off-by: Moritz Kiefer <[email protected]>

readem v2

cd495c9

[ci] Signed-off-by: Moritz Kiefer <[email protected]>

moritzkiefer-da enabled auto-merge (squash) June 12, 2025 08:43

moritzkiefer-da merged commit 12e9b25 into main Jun 12, 2025
60 checks passed

moritzkiefer-da deleted the cocreature/daml-version-checks branch June 12, 2025 09:16

This was referenced Jun 12, 2025

Splitwell should respect the maxDarVersion when waiting for the dar #463

Open

Test against vetted instead of deployed versions in Daml compat tests #1101

Open

Support running tests with an older initial package version set #1014

Support running tests with an older initial package version set #1014

Uh oh!

Conversation

moritzkiefer-da commented Jun 6, 2025

Pull Request Checklist

Cluster Testing

PR Guidelines

Merge Guidelines

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

moritzkiefer-da commented Jun 11, 2025

Uh oh!

moritzkiefer-da commented Jun 12, 2025

Uh oh!

nicu-da left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

meiersi-da left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

isegall-da commented Jun 12, 2025

Uh oh!

Uh oh!