-
Notifications
You must be signed in to change notification settings - Fork 88
updated test-01-simple to test gateway client #547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
1cc796a
to
0be59a0
Compare
Hello @umegbewe @dzikowski |
thanks @kalio007 the idea is fine, this is the script we want to update with a gateway test. However I have a few remarks:
|
Hello @dzikowski , I have updated the test script. I would appreciate your review. |
e2e-network/docker/test-01-simple.sh
Outdated
@@ -8,6 +8,10 @@ FABLO_HOME="$TEST_TMP/../../.." | |||
|
|||
export FABLO_HOME | |||
|
|||
GATEWAY_CLIENT_DIR="$FABLO_HOME/samples/gateway/node" | |||
ORG1_PEER0_ENV="$TEST_TMP/fablo-target/fabric-config/connection-profiles/connection-profile-org1-peer0.env" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH I don't like the approach with env file - I think you can define proper variables right before calling the gateway, for instance. It seems more straightforward:
(
cd "$GATEWAY_CLIENT_DIR" &&
export \
CHANNEL_NAME="..." \
PEER_ORG_NAME="..." \
...
node server.js > "$GATEWAY_CLIENT_OUTPUT_FILE" 2>&1
)
Signed-off-by: kalio007 <[email protected]>
Signed-off-by: kalio007 <[email protected]>
Signed-off-by: kalio007 <[email protected]>
Co-authored-by: Jakub Dzikowski <[email protected]> Signed-off-by: Kalio <[email protected]> Signed-off-by: kalio007 <[email protected]>
Co-authored-by: Jakub Dzikowski <[email protected]> Signed-off-by: Kalio <[email protected]> Signed-off-by: kalio007 <[email protected]>
Co-authored-by: Jakub Dzikowski <[email protected]> Signed-off-by: Kalio <[email protected]> Signed-off-by: kalio007 <[email protected]>
Signed-off-by: kalio007 <[email protected]>
e77d79a
to
8df6d95
Compare
Hi @dzikowski , I have updated the env management. I would like to know if I should change a thing or two, thanks |
please make sure test are working. You can execute |
Hello @umegbewe @dzikowski , I've been running into an issue during testing:
|
Hello @dzikowski, Please check this out when you're free, I'll appreciate your feedback. |
Addresses #542