-
Notifications
You must be signed in to change notification settings - Fork 304
test(satp-hermes): unit tests for the config validators #3933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
edsonCVN
wants to merge
4
commits into
hyperledger-cacti:satp-stg
Choose a base branch
from
edsonCVN:issue-3917
base: satp-stg
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreAugusto11
requested changes
May 29, 2025
...-satp-hermes/src/test/typescript/unit/config-validating-functions/validate-cc-config.test.ts
Show resolved
Hide resolved
...-satp-hermes/src/test/typescript/unit/config-validating-functions/validate-cc-config.test.ts
Outdated
Show resolved
Hide resolved
...atp-hermes/src/test/typescript/unit/config-validating-functions/validate-instance-id.test.ts
Outdated
Show resolved
Hide resolved
...p-hermes/src/test/typescript/unit/config-validating-functions/validate-key-pair-json.test.ts
Outdated
Show resolved
Hide resolved
...p-hermes/src/test/typescript/unit/config-validating-functions/validate-ontology-path.test.ts
Outdated
Show resolved
Hide resolved
...p-hermes/src/test/typescript/unit/config-validating-functions/validate-ontology-path.test.ts
Outdated
Show resolved
Hide resolved
...ermes/src/test/typescript/unit/config-validating-functions/validate-satp-environment.test.ts
Show resolved
Hide resolved
...es/src/test/typescript/unit/config-validating-functions/validate-satp-merge-policies.test.ts
Outdated
Show resolved
Hide resolved
...-satp-hermes/src/test/typescript/unit/config-validating-functions/validate-cc-config.test.ts
Outdated
Show resolved
Hide resolved
AndreAugusto11
requested changes
Jun 11, 2025
...rc/main/typescript/services/validation/config-validating-functions/validate-key-pair-json.ts
Outdated
Show resolved
Hide resolved
...rc/main/typescript/services/validation/config-validating-functions/validate-ontology-path.ts
Outdated
Show resolved
Hide resolved
...-satp-hermes/src/test/typescript/unit/config-validating-functions/validate-cc-config.test.ts
Outdated
Show resolved
Hide resolved
...-satp-hermes/src/test/typescript/unit/config-validating-functions/validate-cc-config.test.ts
Show resolved
Hide resolved
...-satp-hermes/src/test/typescript/unit/config-validating-functions/validate-cc-config.test.ts
Outdated
Show resolved
Hide resolved
...p-hermes/src/test/typescript/unit/config-validating-functions/validate-key-pair-json.test.ts
Show resolved
Hide resolved
...p-hermes/src/test/typescript/unit/config-validating-functions/validate-ontology-path.test.ts
Show resolved
Hide resolved
LordKubaya
reviewed
Jun 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with all @AndreAugusto11 comments.
Signed-off-by: edsonCVN <[email protected]>
Signed-off-by: edsonCVN <[email protected]>
Signed-off-by: edsonCVN <[email protected]>
Signed-off-by: edsonCVN <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Requirements
upstream/main
branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-s
flag when usinggit commit
command. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.