Skip to content

feat(ledger-browser): handle ERC721 token metadata #3894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

musicboy0322
Copy link
Contributor

Primary Change:

  • Modify 'TestERC721.json' to update the 'BaseUrl' for testing about fetching data from 'TokenUri()'.
  • Add the process of fetching data from 'TokenUri()'.
  • Add 'name', 'description', and 'image' columns to the 'ethereum.token_erc721' table in Postgres to store the data.
  • Set up a simple API server to simulate fetching data from 'TokenUri()' for testing purposes.

Fixes #3552

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Copy link
Contributor

@outSH outSH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great! I've left two small comments.

Also, remember to fix the failing CI tests:

  • yarn_codegen
  • yarn_lint (Server is defined but never used in one of the tests)
  • commitlint

@musicboy0322
Copy link
Contributor Author

Hi @outSH! Thanks for the feedback. I will address them.

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@musicboy0322 LGTM assuming @outSH 's comments are addressed.

@musicboy0322
Copy link
Contributor Author

Hi @outSH !

Thanks for the response! I have updated the code based on the two pieces of feedback. If I misunderstood anything, please let me know and I will address it.

Thanks again!

@musicboy0322 musicboy0322 requested a review from outSH May 28, 2025 05:42
Copy link
Contributor

@outSH outSH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. thank you!

@outSH outSH enabled auto-merge (rebase) May 28, 2025 10:15
Primary Change:
* Modify 'TestERC721.json' to update 'BaseUrl' for 'TokenUri()' testing
* Add logic to fetch data from 'TokenUri()'
* Extend 'name', 'description', and 'image' columns in 'token_erc721' table
* Add a simple API server to simulate 'TokenUri()' data responses

Fixes hyperledger-cacti#3552

Signed-off-by: musicboy0322 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(ledger-browser): handle ERC721 token metadata
3 participants