feat(fabric-persistence): save discovery results in a database #3837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outSH
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
petermetz
approved these changes
Apr 5, 2025
|
@outSH The spellchecker caught these: ./packages/cactus-plugin-ledger-connector-fabric/src/main/typescript/plugin-ledger-connector-fabric.ts:1989:7 - Unknown word (msps)
./packages/cactus-plugin-ledger-connector-fabric/src/main/typescript/plugin-ledger-connector-fabric.ts:1989:38 - Unknown word (msps)
./packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v2-2-x/connector-fabric-baseline.test.ts:930:41 - Unknown word (msps)
./packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v2-2-x/connector-fabric-baseline.test.ts:931:54 - Unknown word (msps)
./packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v2-2-x/connector-fabric-baseline.test.ts:959:89 - Unknown word (lifcecycle)
./packages/cactus-plugin-persistence-fabric/src/main/typescript/db-client/db-client.ts:22:32 - Unknown word (Msps)
./packages/cactus-plugin-persistence-fabric/src/main/typescript/db-client/db-client.ts:512:39 - Unknown word (Msps)
./packages/cactus-plugin-persistence-fabric/src/main/typescript/db-client/db-client.ts:606:56 - Unknown word (msps)
./packages/cactus-plugin-persistence-fabric/src/test/typescript/integration/persistence-fabrc-postgresql-db-client.test.ts:413:13 - Unknown word (Msps)
./packages/cactus-plugin-persistence-fabric/src/test/typescript/integration/persistence-fabrc-postgresql-db-client.test.ts:414:14 - Unknown word (Msps)
./packages/cactus-plugin-persistence-fabric/src/test/typescript/integration/persistence-fabrc-postgresql-db-client.test.ts:415:25 - Unknown word (Msps)
./packages/cactus-plugin-persistence-fabric/src/test/typescript/integration/persistence-fabric-functional.test.ts:436:45 - Unknown word (msps)
./packages/cactus-plugin-persistence-fabric/src/test/typescript/integration/sample-data.ts:109:3 - Unknown word (msps)
CSpell: Files checked: 1229, Issues found: 13 in 6 files.
ERROR: "spellcheck" exited with 1. |
outSH
force-pushed
the
persist_fabric_discovery_results_pr
branch
2 times, most recently
from
c93ec8e to
754b896
Compare
|
Fixed some minor bugs after doing a complete setup + updated the test insert data |
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Apr 11, 2025
- Add `Discovery` tab to Fabric App for showing discovered fabric network components by MSP. - Update REAMDE. - Fix responsiveness of main App selection screen. Depends on hyperledger-cacti#3837 Closes hyperledger-cacti#3837 Signed-off-by: Michal Bajer <[email protected]>
5 tasks
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Apr 11, 2025
- Add `Discovery` tab to Fabric App for showing discovered
fabric network components by MSP.
- Update REAMDE.
- Fix responsiveness of main App selection screen.
Depends on hyperledger-cacti#3837
Closes hyperledger-cacti#3554
Signed-off-by: Michal Bajer <[email protected]>
|
|
|
🎉 All dependencies have been resolved ! |
- Add `discoverNetwork` function for saving current fabric network structure to the database. - Add `DiscoverNetworkEndpointV1` endpoint for refreshing the discovery results. - Add tests for new functions. Depends on hyperledger-cacti#3726 Closes hyperledger-cacti#3836 Signed-off-by: Michal Bajer <[email protected]>
outSH
force-pushed
the
persist_fabric_discovery_results_pr
branch
from
754b896 to
8a5111d
Compare
|
🎉 Great news! Looks like all the dependencies have been resolved:
💡 To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
|
@hyperledger-cacti/cacti-maintainers Please have a look in spare time please |
RafaelAPB
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
discoverNetworkfunction for saving current fabricnetwork structure to the database.
DiscoverNetworkEndpointV1endpoint for refreshingthe discovery results.
Depends on #3726
Depends on #3856
Closes #3836
Signed-off-by: Michal Bajer [email protected]
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.