This repository was archived by the owner on Jan 27, 2022. It is now read-only.
Cleaning Dockerfile from openssl dependency #643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankajgoyal2
requested review from
danintel,
dcmiddle,
EugeneYYY,
karthikamurthy,
manju956,
manojgop,
Ram-srini,
rranjan3,
SriharshaSubbakrishna and
TomBarnes
as code owners
rranjan3
approved these changes
Jul 27, 2020
manojgop
reviewed
Jul 27, 2020
| @@ -65,68 +65,6 @@ RUN apt-get update \ | |||
| RUN pip3 install setuptools | |||
|
|
|||
|
|
|||
| # -------------=== Build openssl_image ===------------- | |||
There was a problem hiding this comment.
Does verify report in Avalon shell use openSSL. @manju956 @pankajgoyal2 can you please confirm if verify report will work if we remove openSSL (untrusted) from Avalon shell docker image
There was a problem hiding this comment.
Generic client uses it to verify the AVR report of worker. We should make verify-report cpp module as independent package, so that client will install only that CPP module and Avalon SDK.
There was a problem hiding this comment.
Verify_report module is built as separate python package. It depends on openssl as client invokes untrusted cpp code to do verification of attestation data.
Signed-off-by: pankajgoyal2 <[email protected]>
danintel
approved these changes
Jul 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: pankajgoyal2 [email protected]