feat: Move Request server util method to RequestExt #1772
+156
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't seem like an improvement to me. |
tottoto
force-pushed
the
request-ext
branch
2 times, most recently
from
5e35c04 to
2da3401
Compare
tottoto
force-pushed
the
request-ext
branch
from
2da3401 to
988f421
Compare
tottoto
force-pushed
the
request-ext
branch
from
988f421 to
56dbb7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
These utility functionalities seem to be more practical APIs than the other basic ones. Moving them to an extension trait can keep the request implementation more basic. The drawback is that users need to import the trait to use these functionalities.
Solution
Adds an extension trait for request and moves these functionalities to the trait.