examples: allow configurable uds socket paths #1613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update unix domain socket examples to show configurable paths. It demonstrates a way of configuring the UDS client using the ustr crate to meet the closure capture requirements of the connector service_fn. Fixes: hyperium#1611 Refs: hyperium#1612
LucioFranco
reviewed
Feb 2, 2024
|
|
||
| #[cfg(unix)] | ||
| #[tokio::main] | ||
| async fn main() -> Result<(), Box<dyn std::error::Error>> { | ||
| // Path needs to be a static str due to service_fn FnMut. | ||
| let path = match env::var("EXAMPLE_UDS_PATH") { | ||
| Ok(path) => ustr(path.as_ref()).as_str(), |
There was a problem hiding this comment.
I want to say converting a path to a string should be possible without a third party crate?
There was a problem hiding this comment.
Would something like a OnceLock<String> work? AFAICT a &'static str is required. I used ustr because in an actual application one may have multiple copies of the same client but with different endpoints -- I think you'd end up reimplementing ustr in that case?
There was a problem hiding this comment.
Perhaps there is something obvious I missed, but when using a String, and for the reason I filed that other linked issue...
expected a closure that implements the `FnMut` trait, but this closure only implements `FnOnce`
required for `ServiceFn<{closure@examples/src/uds/client.rs:29:44: 29:57}>` to implement `Service<Uri>`
required for `ServiceFn<{closure@examples/src/uds/client.rs:29:44: 29:57}>` to implement `MakeConnection<Uri>`rustc[Click for full compiler diagnostic](rust-analyzer-diagnostics-view:/diagnostic%20message%20%5B3%5D?3#file%3A%2F%2F%2FUsers%2Fkris%2FCode%2Fkriswuollett%2Ftonic%2Fexamples%2Fsrc%2Fuds%2Fclient.rs)
client.rs(29, 10): the requirement to implement `FnMut` derives from here
client.rs(31, 33): closure is `FnOnce` because it moves the variable `path` out of its environment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update unix domain socket examples to show configurable paths. It demonstrates a way of configuring the UDS client using the
ustrcrate to meet the closure capture requirements of the connector service_fn.Fixes: #1611
Refs: #1612
Motivation
Share a solution of how to configure a UDS client path at runtime.
Solution
Use the
ustrcrate to vend a&'static strto the UDS connection building closure.