Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I adopted the given example in my own code, however, I was receiving occasional error messages because the connection was not ready. This should help API users encountering the same error.
I wonder also if you might consider changing the API to reflect the necessity of using
sender.ready()
before dispatching a request. Rust, as a language and ecosystem, (as I'm sure you know) often provides compile-time guarantees so that call patterns must reflect contracts. It would be ideal to have a compile-time constraint hat enforces the inability to use a sender before it is ready. Perhaps thehandshake
method should return(impl Future<Output=Sender>, Connection)
instead of simply(Sender, Connection)
.