Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update basic.md #56

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

aaronpkelly
Copy link

The full example has at https://github.com/hyperium/hyper/blob/master/examples/client.rs will not compile straight away, as it has an additional dependency which is not mentioned in the guide

The full example has at https://github.com/hyperium/hyper/blob/master/examples/client.rs will not compile straight away, as it has an additional dependency which is not mentioned in the guide
@tobymurray
Copy link

As a new user, I also ran into this. I started with the documentation, appreciated the fork between "client" and "server, went to https://hyper.rs/guides/client/basic/ and then to the "full example" which failed to compile. It is not intuitive that the dependencies for the example I was just reading are different than the dependencies for the example I'm lead to, so my first experience with this library was:

error[E0433]: failed to resolve: use of undeclared type or module `pretty_env_logger`
  --> src/main.rs:11:5
   |
11 |     pretty_env_logger::init();
   |     ^^^^^^^^^^^^^^^^^ use of undeclared type or module `pretty_env_logger`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0433`.

Whether this is updated as described in the pull request or reworked to make it more clear, I think it's worthwhile to change something so there's as little friction as possible on new user flow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants