use async fn in traits in SendStream
#235
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
at the moment there are two trait functions to send data.
send_datato prepare data for sendingpoll_readyto poll the stream until the data is sentThis PR uses the async fn in traits feature to introduce the
async fn send_datafunction in theSendStreamtrait.Advantages:
h3_quinncrateh3_quinnpanics if some functions are called while the boxed future is not ready. Users ofh3_quinn+h3might be able to get this, for example when usingRequestStreamin a Mutex. (but I'm not sure)send_datawithoutpoll_readyDisadvantages
Open:
Is it worth exploring this approach?