simplify traits #200
simplify traits #200
Conversation
There was a problem hiding this comment.
The poll merger looks good to me. Since we need to document expectations for different close scenarios anyway, it may make sense to handle the close type situation in this PR as well. I would recommend the enum proposal from #177 B2 (replace Error with Close enum).
In any case, I think the expectation that the quic implementation always emits a Close/Error via poll_incoming on termination should be documented.
Stream opening itself can't fail (only block), unless the connection is terminated. Therefore I think it would be good to remove the errors from poll_open_*. That removes any ambiguity how Closes are communicated (only via poll_incoming). I'm not even convinced returning an Option is necessary. Just Poll::Pending should be fine as well.
| /// | ||
| /// Returning `None` implies the connection is closing or closed. | ||
| fn poll_accept_bidi( | ||
| /// Poll the connection for incoming streams. |
There was a problem hiding this comment.
Add: /// Returning an Err implies the connection is closing or closed.
|
Thanks for the review.
I will continue to work on this and implement #177 B2. I Think this are my next tasks:
|
|
@Ruben2424 Is this PR in a state where it's ready for review? |
@dongcarl you can review the changes if you want. But there is still some work left to improve the error types. |
…type. Maybe some of this stuff must be undone.
|
I think i will not continue on this as one big pr. Instead I probably will split them up into multiple smaller ones which are easier to review. |
This is a not 100% working change to explore some of the proposed changes from #177.