move datagram to separate crate #199
Conversation
There was a problem hiding this comment.
Generally looks great, good work!
Might be good if @darioalessandro or @ten3roberts could look, to see if they can still use it.
h3-quinn/Cargo.toml
Outdated
| @@ -21,6 +21,7 @@ quinn = { version = "0.11", default-features = false, features = [ | |||
| tokio-util = { version = "0.7.9" } | |||
| futures = { version = "0.3.28" } | |||
| tokio = { version = "1", features = ["io-util"], default-features = false } | |||
| h3-datagram = { path = "../h3-datagram" } | |||
There was a problem hiding this comment.
Wondering, should it be optional? Is there enough code in here that people would benefit if they didn't need to compile it?
There was a problem hiding this comment.
Wondering, should it be optional? Is there enough code in here that people would benefit if they didn't need to compile it?
Changed it.
Ruben2424
changed the title
@seanmonstar i think you can continue with the review. |
|
I'm no longer using WT as much, but I had a look and it looks great. Nothing suspicious in the code, and good use of pub/pub(crate) and doc-hidden where needed 👍 Thank you |
The goal of This PR is to separate the h3-datagram logic from the
h3crate providing a new crateh3-datagram.