feat: Support for sum metrics in charts #622
Conversation
|
dhable
force-pushed
the
dhable/hdx-1337-sum-metrics
branch
2 times, most recently
from
1754ad5 to
fc37b55
Compare
|
I didn't add a changeset file here. I'm thinking that we would just have a single changeset on the feature branch level. |
| }); | ||
|
|
||
| // it('should generate sql for multiple gauge metrics', async () => { |
There was a problem hiding this comment.
supporting multiple metrics in a single query is another ticket.
Add query rendering support for CTEs and then using a CTE to support HyperDX v1 query logic to get sum metrics working in v2. Ref: HDX-1337
dhable
force-pushed
the
dhable/hdx-1337-sum-metrics
branch
from
fc37b55 to
d609fe7
Compare
The condidion field on the select object is used by the UI filters. To avoid mixing the metric name filter with the UI filter, the name condition has been moved to the `where` condition.
| @@ -790,7 +790,7 @@ function translateMetricChartConfig( | |||
| any(Attributes) OVER (ROWS BETWEEN 1 PRECEDING AND 1 PRECEDING) AS PrevAttributes, | |||
| IF(AggregationTemporality = 1, | |||
| Value,IF(Value - PrevValue < 0 AND Attributes = PrevAttributes,Value, | |||
| IF(Attributes != PrevAttributes, 0, Value - PrevValue))) as Rate | |||
| IF(cityHash64(Attributes) != cityHash64(PrevAttributes), 0, Value - PrevValue))) as Rate | |||
There was a problem hiding this comment.
I think we want to actually run this on the subselect first, otherwise we'll be rehashing a lot more than we need to.
dhable
force-pushed
the
dhable/hdx-1337-sum-metrics
branch
from
dac30e4 to
915a77c
Compare
Add query rendering support for CTEs and then using a CTE to support HyperDX v1 query logic to get sum metrics working in v2.
Ref: HDX-1337