Parse tensor infos + E2E test #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-c
commented
Mar 8, 2024
| const buf = await ( | ||
| await fetch(URL_LLAMA, { | ||
| headers: { | ||
| Range: 'bytes=0-999999', |
There was a problem hiding this comment.
loading the first 1MB
platypii
approved these changes
Mar 9, 2024
There was a problem hiding this comment.
Really nice PR! Thanks for contributing back, and especially thanks for bringing my test coverage up from 81% to 95%! 馃殌
I tested locally and things look good, except the API change to return an object with { metadata, tensorInfos } would have broken my demo so I added a commit to fix that.
Since the API changed, but it is in pre-1.0, I will publish a new minor revision shortly. Thanks @julien-c !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃憢
(also related but implemented a tiny bit differently: huggingface/huggingface.js#540)