Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG serialization big changes #983

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

SVG serialization big changes #983

wants to merge 19 commits into from

Conversation

katehryhorenko
Copy link
Contributor

@katehryhorenko katehryhorenko commented May 19, 2023

BACKGROUND:

  • We needed ability to create PDF drawing. But we were using Svg.net library that didn't support it.

DESCRIPTION:

  • All common SVG classes don't have any dependences from a third libraries
  • A new SkDrawingTool that is using Skia library to create svg and pdf drawings
  • Removed all referenced to Svg.net from SvgSection class. The only reference that is left is used inside deprecated method
  • I left SvgSectionOld class with old SvgSection logic to support prev. implementation that now is marked as deprecated
  • All properties inside SvgContext class are third party free. Old properties are marked as deprecated

TESTING:

  • I tested this changes inside PanelMaxExporter function and inside StockingPlanExporter

FUTURE WORK:

  • Add comments
  • Add SvgNetDrawingTool implementation. We already know how to use Svg.Net. It makes sense to add SvgNetDrawingTool implementation
  • Move more common logic to SvgBaseDrawing and to BasaDrawingTool
  • SvgFaceElevation must inherit SvgBaseDrawing

REQUIRED:

  • All changes are up to date in CHANGELOG.md.

This change is Reviewable

@katehryhorenko katehryhorenko marked this pull request as ready for review July 10, 2023 23:38
katehryhorenko added 4 commits July 19, 2023 09:28
# Conflicts:
#	Elements.Serialization.SVG/src/SvgSection.cs
# Conflicts:
#	Elements/src/GeometricElement.cs
#	Elements/src/Representations/SolidRepresentation.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants