Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IFC with RepresentationInstances #1066

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

IFC with RepresentationInstances #1066

wants to merge 17 commits into from

Conversation

srudenkoamc
Copy link
Contributor

@srudenkoamc srudenkoamc commented Nov 29, 2023 •
edited

BACKGROUND:

  • IFC supports multiple instances concept. It may be implemented with RepresentationInstances.

DESCRIPTION:

  • IFC -> Hypar now supports RepresentationInstances.
  • Fixed several conversion bugs.

TESTING:

  • Used IFC tests for testing.
  • Added a test to check Hypar -> IFC -> Hypar conversion.

FUTURE WORK:

  • RepresentationInstances of windows and doors that created from BREP are placed incorrectly (but the Element transform is correct).

This change is Reviewable

srudenkoamc and others added 17 commits November 22, 2023 17:42
@srudenkoamc
Added FromIfcElementRepresentationExtractor class
d16c72e
@srudenkoamc
FromIFC: Representations -> RepresentationInstances
fb85e8e
@srudenkoamc
Small refactoring
7fcc6d6
@srudenkoamc
Added fallback material for MaterialExtractor
f623877
@srudenkoamc
Extrude.LocalTransform is now used instead of ExtrudeTransform property
fec1ac9
@srudenkoamc
Fixed Floor transform
a90a3d3
@srudenkoamc
RepresentationInstances for converted IfcMappedItem
b890e91
@srudenkoamc
Added fallback string when the Name is null
ae7aa70
@srudenkoamc
Added origin correction for doors and windows
b251b1b
@srudenkoamc
Fixed mapping transform for converted IfcMappedItem
639575f
@srudenkoamc
Update IFCTests.cs
46acce6
@srudenkoamc
Merge branch 'master' into ifc-representation-instances
be7f14d
@srudenkoamc
Update IFCTests.cs
7b7836b
@srudenkoamc
Added door origin correction during Element->IFC conversion
6b9c4dd
@srudenkoamc
Fixed Column bug
7ac4986 
The origins of columns were changing during the Hypar->IFC->Hypar conversion.
@srudenkoamc
Added atest to check Hypar -> IFC -> Hypar conversion
1b5b025
@srudenkoamc
Merge branch 'master' into ifc-representation-instances
735417f
@srudenkoamc srudenkoamc marked this pull request as ready for review November 30, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@srudenkoamc