Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix repr and hy-repr for f-strings #2053

Merged
merged 6 commits into from
May 8, 2021
Merged

Fix repr and hy-repr for f-strings #2053

merged 6 commits into from
May 8, 2021

Conversation

Kodiologist
Copy link
Member

Supersedes #2033.

@Kodiologist
Small docs update for f-strings
abb1121 
We no longer support Pythons too old to have f-strings.
@Kodiologist
Remove some Python 2 compatibility code
8da9c68
@allison-casey
Copy link
Contributor

allison-casey commented May 5, 2021 •
edited
Loading

Nice! Is the only thing left for hy-repr #1873 and #1617?

@allison-casey allison-casey self-requested a review May 5, 2021 19:41
@Kodiologist
Copy link
Member Author

No, I also have some changes to make left over from #1550.

@allison-casey
Copy link
Contributor

i'll take a stab at #1873 then. I'll get a review for this in after work

@Kodiologist Kodiologist force-pushed the hy-repr-fstring branch 3 times, most recently from 9098d74 to 8ef12f5 Compare May 6, 2021 17:35
@Kodiologist Kodiologist merged commit e1150cf into hylang:master May 8, 2021
@Kodiologist Kodiologist deleted the hy-repr-fstring branch June 15, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allison-casey allison-casey allison-casey approved these changes

@scauligi scauligi scauligi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kodiologist @allison-casey @scauligi