Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add longer startup timeout #103

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jams2
Copy link

@jams2 jams2 commented Feb 7, 2021

I believe this fixes #85. I was getting the error

hy-shell--redirect-check-prompt-regexp: No prompt found or ‘comint-prompt-regexp’ not set properly

when running the tests, and when starting the first hy buffer of an emacs session (hy process starting up for jedhy). It may have been occurring at other times, but I did not note the exact circumstances. The was caused by accept-process-output timing out before the hy REPL writes its banner text ("hy 0.20.0 ..."). I've added a variable (hy-shell--startup-timeout) with a default of 3 seconds, and this seems to fix it for me.

@swapneils
Copy link

Since this isn't in the Master copy yet: can the fix be added to a MELPA download without causing undue difficulties, i.e. with updating hy-mode in the future?

I've only recently started studying LISP, and being a perfectionist downloaded Emacs (and with it hy-mode and paradox-mode, among other packages) for that purpose, so I'm not fully aware of how Emacs interacts with packages.

@jams2
Copy link
Author

jams2 commented May 30, 2021

@swapneils emacs package management is pretty painless IME. You could, for example, check out this branch (or the main branch on my fork) into ~/.emacs.d, then run M-x package-install-file, ~/.emacs.d/hy-mode/. If at some point this repository is updated, the package metadata should be updated to increment its version number, so updating from M-x package-list-packages should smoothly upgrade to the newer version (and you could manually remove ~/.emacs.d/hy-mode/).

brandonwillard
brandonwillard previously approved these changes Oct 16, 2021
@brandonwillard
Copy link
Member

This needs to be rebased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No prompt found or ‘comint-prompt-regexp’ not set properly
3 participants