-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: screen state #1446
base: main
Are you sure you want to change the base?
feat: screen state #1446
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Added window state persistence functionality to maintain window position, size, and maximized state between application sessions.
- Added
configPath
to store window state inHydraScreenState.json
within user data directory - Implemented
saveScreenConfig
method usingfs/promises
to persist window bounds and maximized state - Added
loadScreenConfig
to restore previous window state on startup with error handling - Added window state saving on close event to capture final window configuration
- Integrated window state restoration into
createMainWindow
with proper maximized state handling
💡 (4/5) You can add custom instructions or style guidelines for the bot here!
1 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
@KelvinDiasMoreira I think that you better take advantage of the existing storage that we use (LevelDB) instead of writing the info into a JSON file. Could you please do that? Thank you for your interest in contributing. |
|
@thegrannychaseroperation can you review ? |
When submitting this pull request, I confirm the following (please check the boxes):
Fill in the PR content: