[Bugfix] VideoCaptureProperties being an int64 does not correctly unpack the parameters for OpenCV VideoCapture.open #1250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch changes the type of `VideoCaptureProperties` to `int32`. It is currently set to `int`. This breaks `VideoCapture_OpenDeviceWithAPIParams` because it doesn't correclty unroll the slice into the `std::vector<int>` here:
```c++
bool VideoCapture_OpenDeviceWithAPIParams(VideoCapture v, int device, int apiPreference, int *paramsv, int paramsc) {
std::vector< int > params;
for( int i = 0; i< paramsc; i++) {
params.push_back(paramsv[i]);
}
return v->open(device, apiPreference, params);
}
```
With `int64` this for loop will create only zeros in the value parts of the array that OpenCV expects (`[p1, v1, ..., pn, vn]`).
Changing it to `int32` unpacks the slice correctly and OpenCV will pass the parameters correctly to the respective VideoCapture backends.
tnolle
changed the title
Member
|
Hello @tnolle thank you for the pull request. I changed the branch to @diegohce can you take a peek at this please? |
Contributor
Author
|
@deadprogram, oops, you're right. Sorry about that and thanks for changing it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes the type of
VideoCapturePropertiestoint32. It is currently set toint. This breaksVideoCapture_OpenDeviceWithAPIParamsbecause it doesn't correclty unpack the slice into thestd::vector<int>here:With
int64this for loop will create only zeros in the value parts of the array that OpenCV expects ([p1, v1, ..., pn, vn]).Changing it to
int32unpacks the slice correctly and OpenCV will pass the parameters correctly to the respective VideoCapture backends.