Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix file download problem with a urls which includes a port #9 #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix file download problem with a urls which includes a port #9 #10

wants to merge 1 commit into from

Conversation

jhezjkp
Copy link

@jhezjkp jhezjkp commented Aug 13, 2016

fix #9

@huydx
Copy link
Owner

huydx commented Aug 15, 2016 •
edited
Loading

Hi @jhezjkp , thanks for your effort. net package has a method called SplitHostPort, may it be better.
And about the test, confirm that the initialize of HttpDownloader is not panic may be more appropriate.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

can’t download file with port specified in url
2 participants
@jhezjkp @huydx