8524 Enhance file access control and caching logic #8525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 19, 2025 09:53
- Introduced `isFilePubliclyAccessible` function to determine if files can be accessed publicly based on entity publication status and user authentication. - Added `getCacheControlHeader` function to set appropriate caching headers based on instance privacy and file accessibility. - Updated file download route to include Cache-Control and Last-Modified headers. - Expanded tests to cover new caching behavior and conditional requests for file downloads.
- Simplified permission checks in `checkEntityPermission` and `isFilePubliclyAccessible` functions. - Adjusted database queries to optimize data retrieval for related entities. - Enhanced test setup for public and private instance scenarios in `downloadRoute.spec.ts` to ensure accurate user context handling.
- Cleaned up formatting in `MongoPermissionsDataSource` and `MongoV1ConnectionsDataSource` classes for better readability. - Improved error handling in `isFilePubliclyAccessible` function to ensure safety when querying related entities. - Updated tests in `downloadRoute.spec.ts` to reflect changes in file access logic and ensure proper handling of unpublished entities.
- Updated import statement in `commonTypes.d.ts` for cleaner syntax. - Adjusted array syntax in `connectionType.d.ts` for consistency. - Simplified nested type definition in `settingsType.d.ts` for improved readability.
…oint-cache-control-headers
…load route. Added error handling for missing creationDate and updated tests to cover edge cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isFilePubliclyAccessiblefunction to determine if files can be accessed publicly based on entity publication status and user authentication.getCacheControlHeaderfunction to set appropriate caching headers based on instance privacy and file accessibility.fixes #8524