Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6873 - Moved login inside changes array #6886

Merged
merged 7 commits into from
Jun 19, 2024
Merged

6873 - Moved login inside changes array #6886

merged 7 commits into from
Jun 19, 2024

Conversation

RafaPolit
Copy link
Member

fixes #6873

PR checklist:

  • Update READ.me ?
  • Update API documentation ?

QA checklist:

  • Smoke test the functionality described in the issue
  • Test for side effects
  • UI responsiveness
  • Cross browser testing
  • Code review

@LaszloKecskes LaszloKecskes self-requested a review June 12, 2024 11:52
@LaszloKecskes LaszloKecskes changed the title Moved login insde changes array Moved login inside changes array Jun 12, 2024
LaszloKecskes
LaszloKecskes approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@LaszloKecskes LaszloKecskes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works. Functionally tested through a simple local sync setup and logging logins.

Optionally, we have a syncedPromiseLoop function in the shared folder, if you'd like to simplify the reduce-await syntax.

@RafaPolit RafaPolit changed the title Moved login inside changes array 6873 - Moved login inside changes array Jun 13, 2024
@txau txau merged commit c7b6dae into development Jun 19, 2024
15 checks passed
@txau txau deleted the 6873-sync-login-refactor branch June 19, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaszloKecskes LaszloKecskes LaszloKecskes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move Sync login logic only if LastChanges has items
3 participants
@RafaPolit @LaszloKecskes @txau