Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty metadata as empty array #6683

Merged
merged 18 commits into from
Jun 25, 2024

Conversation

LaszloKecskes
Copy link
Contributor

fixes #6568

PR checklist:

  • Update READ.me ?
  • Update API documentation ?

QA checklist:

  • Smoke test the functionality described in the issue
  • Test for side effects
  • UI responsiveness
  • Cross browser testing
  • Code review

@LaszloKecskes LaszloKecskes marked this pull request as draft April 22, 2024 13:25
@LaszloKecskes LaszloKecskes marked this pull request as ready for review April 23, 2024 08:12
Copy link
Contributor

@fnocetti fnocetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. I left a couple questions.
I will proceed to test it.

entities: correctEntities,
};

const fixtures: Fixture = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a case in which the entity has some metadata properties with correct values and some others to be fixed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, will do so.

app/api/suggestions/specs/suggestions.spec.ts Outdated Show resolved Hide resolved
app/api/entities/entities.js Show resolved Hide resolved
Copy link
Contributor

@fnocetti fnocetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works!

@LaszloKecskes LaszloKecskes merged commit 98615b6 into development Jun 25, 2024
16 of 17 checks passed
@LaszloKecskes LaszloKecskes deleted the 6568_empty_metadata_as_empty_array branch June 25, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty metadata values should always be set to empty arrays
2 participants