Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/Minor improvement to Cube connector #7033

Merged
merged 2 commits into from
May 20, 2024

Conversation

mlguys
Copy link
Contributor

@mlguys mlguys commented May 20, 2024

Handle null last traded price

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

  • Implemented all_trading_pairs
  • Added handling for null last traded price

Tests performed by the developer:

Tips for QA testing:

Handle null last traded price
@rapcmia rapcmia self-requested a review May 20, 2024 13:20
Copy link

@rapcmia rapcmia merged commit fef8b8f into development May 20, 2024
2 checks passed
@rapcmia rapcmia deleted the feat/cube-improvement-20-may branch May 20, 2024 15:02
@rapcmia
Copy link
Contributor

rapcmia commented May 20, 2024

Merged to development and part of release version 1.28.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Release version 1.28.0
Development

Successfully merging this pull request may close these issues.

None yet

2 participants