Merge pull request #494 from humanmade/psalm-wordpress-version-pin

Switch to fixed version of Psalm Plugin WordPress
humanmade · Feb 19, 2021 · 129f84f · 129f84f
2 parents d58519b + aa27da7
commit 129f84f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/composer.json b/composer.json
@@ -28,7 +28,7 @@
 	"require-dev": {
 		"phpunit/phpunit": "7.5",
 		"pcov/clobber": "^2.0",
-		"humanmade/psalm-plugin-wordpress": "dev-master"
+		"humanmade/psalm-plugin-wordpress": "^1.0"
 	},
 	"scripts": {
 		"test": "./tests/run-tests.sh",

diff --git a/tests/test-s3-uploads.php b/tests/test-s3-uploads.php
@@ -105,8 +105,8 @@ public function test_generate_attachment_metadata_for_mp4() {
 		) );
 
 		$meta_data = wp_generate_attachment_metadata( $attachment_id, $test_file );
-		$this->assertEquals( 'video/mp4', $meta_data['mime_type'] );
-		$this->assertEquals( 'quicktime', $meta_data['dataformat'] );
+		// Video mimetype can vary depending on platform configuration
+		$this->assertTrue( in_array( $meta_data['mime_type'], [ 'video/quicktime', 'video/mp4' ], true ) );
 		$this->assertEquals( 320, $meta_data['width'] );
 		$this->assertEquals( 240, $meta_data['height'] );
 	}