fix: extension testing with new chromium headless

hugomrdias · Feb 10, 2025 · 88b5559 · 88b5559
1 parent 0687f39
commit 88b5559
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 4 deletions.
diff --git a/src/runner.js b/src/runner.js
@@ -95,10 +95,17 @@ export class Runner {
     this.server = server
 
     // download playwright if needed
-    const pw = await getPw(this.options.browser, this.options.debug)
+    const pw = await getPw(
+      this.options.browser,
+      this.options.debug,
+      this.options.extension
+    )
 
     /** @type {import('playwright-core').LaunchOptions} */
     const pwOptions = {
+      // optin to new chromium headless for extension testing
+      // https://github.com/microsoft/playwright/issues/33566
+      channel: this.options.extension ? this.options.browser : undefined,
       headless: !this.options.debug,
       devtools: this.options.browser === 'chromium' && this.options.debug,
       args: this.options.extension

diff --git a/src/types.d.ts b/src/types.d.ts
@@ -11,7 +11,7 @@ export interface RunnerOptions {
   testRunner: TestRunner
   cwd: string
   extensions: string
-  browser: 'chromium' | 'firefox' | 'webkit'
+  browser: 'chromium' | 'firefox' | 'webkit' | 'chromium-headless-shell'
   debug: boolean
   mode: 'main' | 'worker' | 'node'
   incognito: boolean

diff --git a/src/utils/index.js b/src/utils/index.js
@@ -293,14 +293,15 @@ export async function redirectConsole(msg) {
  * @template {RunnerOptions["browser"]} TBrowser
  * @param {TBrowser} browserName
  * @param {boolean} debug
+ * @param {boolean} extension
  * @returns {Promise<import('playwright-core').BrowserType<import('../types').PwResult<TBrowser>>>}
  */
-export async function getPw(browserName, debug) {
+export async function getPw(browserName, debug, extension) {
   if (!['chromium', 'firefox', 'webkit'].includes(String(browserName))) {
     throw new Error(`Browser not supported: ${browserName}`)
   }
 
-  if (browserName === 'chromium' && !debug) {
+  if (browserName === 'chromium' && !debug && !extension) {
     // @ts-ignore
     browserName = 'chromium-headless-shell'
   }
@@ -328,6 +329,7 @@ export async function getPw(browserName, debug) {
     return api.chromium
   }
 
+  // @ts-ignore
   return api[browserName]
 }