Skip to content

Disable custom MRA kernels for ROCm #38738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 13, 2025

Conversation

ahadnagy
Copy link
Contributor

@ahadnagy ahadnagy commented Jun 10, 2025

What does this PR do?

This PR is a clone of #38578 with a small fix, this time targeting main. It's part of a series of PRs propagating back fixes for AMD devices from https://github.com/huggingface/transformers/tree/amd-hf-ci-branch .

TLDR; it disables the MRA CUDA extensions for AMD devices as the kernels are broken on the platform at the moment.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@ahadnagy
Copy link
Contributor Author

@ivarflakstad

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@Rocketknight1
Copy link
Member

Pinging @mht-sharma for ROCm

Copy link
Contributor

@mht-sharma mht-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Akos, LGTM!

@ivarflakstad ivarflakstad merged commit 1031ed5 into huggingface:main Jun 13, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants