from 1.11.0, torchao.prototype.low_bit_optim is promoted to torchao.optim #38689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torchao.optim Signed-off-by: YAO Matrix <[email protected]>
|
cc @MekkCyber |
SunMarc
approved these changes
Jun 10, 2025
tests/trainer/test_trainer.py
Outdated
Comment on lines
5373
to
5376
| has_torchao_optim = version.parse(importlib.metadata.version("torchao")) >= version.parse("0.11.0") | ||
| AdamW4bitModule = torchao.optim.AdamW4bit if has_torchao_optim else torchao.prototype.low_bit_optim.AdamW4bit | ||
| AdamW8bitModule = torchao.optim.AdamW8bit if has_torchao_optim else torchao.prototype.low_bit_optim.AdamW8bit | ||
|
|
There was a problem hiding this comment.
just fix the import, we will always use the latest version of torchao
There was a problem hiding this comment.
@SunMarc , done, pls take a look, thx
yao-matrix
changed the title
Signed-off-by: YAO Matrix <[email protected]>
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
lmarshall12
pushed a commit
to lmarshall12/transformers
that referenced
this pull request
Jun 12, 2025
…ptim (huggingface#38689) * since 1.11.0, torchao.prototype.low_bit_optim is promoted to torchao.optim Signed-off-by: YAO Matrix <[email protected]> * fix review comments Signed-off-by: YAO Matrix <[email protected]> --------- Signed-off-by: YAO Matrix <[email protected]> Co-authored-by: Marc Sun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per https://github.com/pytorch/ao/tree/main/torchao/prototype, from1.11.0,
torchao.prototype.low_bit_optimis promoted totorchao.optim, so will haveAttributeError: module 'torchao.prototype' has no attribute 'low_bit_optim'w/ torchao 1.11.0.@ydshieh , pls help review, thx.