Skip to content

chore: fix typos in the tests directory #36813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Mar 21, 2025
Merged

Conversation

threewebcode
Copy link
Contributor

@threewebcode threewebcode commented Mar 19, 2025

What does this PR do?

fix typos in the tests directory

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@github-actions github-actions bot marked this pull request as draft March 19, 2025 07:19
Copy link
Contributor

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. When it is ready for review, please click the Ready for review button (at the bottom of the PR page).

@threewebcode threewebcode marked this pull request as ready for review March 19, 2025 07:19
@github-actions github-actions bot requested a review from ydshieh March 19, 2025 07:19
@threewebcode
Copy link
Contributor Author

@ydshieh Please help take a look.

Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I have a few nit questions 🙏

@threewebcode threewebcode requested a review from ydshieh March 19, 2025 14:45
Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just 3 nits (that I misssed in the previous review) and we are good.

(there is no need to click Update branch frequently 🙏 )

@threewebcode
Copy link
Contributor Author

just 3 nits (that I misssed in the previous review) and we are good.

(there is no need to click Update branch frequently 🙏 )

Okay, I will fix the conflicts when you update branch to synchronize the latest codes from main branch.

@ydshieh
Copy link
Collaborator

ydshieh commented Mar 21, 2025

There is actually no conflict :-) . I merge this PR and thank you again 💯

@ydshieh ydshieh merged commit 26c8349 into huggingface:main Mar 21, 2025
21 checks passed
@threewebcode threewebcode deleted the develop branch March 21, 2025 12:08
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request May 14, 2025
* chore: fix typos in the tests

* chore: fix typos in the tests

* chore: fix typos in the tests

* chore: fix typos in the tests

* chore: fix typos in the tests

* chore: fix typos in the tests

* chore: fix typos in the tests

* chore: fix typos in the tests

* chore: fix typos in the tests

* chore: fix typos in the tests

* chore: fix typos in the tests

* chore: fix typos in the tests

* chore: fix typos in the tests

* fix: format codes

* chore: fix copy mismatch issue

* fix: format codes

* chore: fix copy mismatch issue

* chore: fix copy mismatch issue

* chore: fix copy mismatch issue

* chore: restore previous words

* chore: revert unexpected changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants