Skip to content

chore: fix typos in language models #36586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 10, 2025
Merged

Conversation

threewebcode
Copy link
Contributor

@threewebcode threewebcode commented Mar 6, 2025

What does this PR do?

Fix some typos in the language models.

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@github-actions github-actions bot marked this pull request as draft March 6, 2025 12:57
Copy link
Contributor

github-actions bot commented Mar 6, 2025

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. When it is ready for review, please click the Ready for review button (at the bottom of the PR page).

@threewebcode threewebcode marked this pull request as ready for review March 6, 2025 12:58
@threewebcode
Copy link
Contributor Author

@Rocketknight1 Please take a look.

Copy link
Member

@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, these all look correct. Thank you!

@Rocketknight1
Copy link
Member

@threewebcode the CI is failing because one of the updated texts is Copied from another model, and those copies have to stay in sync. Please check the errors in the CI or look for Copied from tags, and update the copies appropriately. Alternatively, you can simply update the base and run make fix-copies to propagate that change.

@threewebcode
Copy link
Contributor Author

@threewebcode the CI is failing because one of the updated texts is Copied from another model, and those copies have to stay in sync. Please check the errors in the CI or look for Copied from tags, and update the copies appropriately. Alternatively, you can simply update the base and run make fix-copies to propagate that change.

Thanks for your feedback. Let me check.

@threewebcode
Copy link
Contributor Author

threewebcode commented Mar 7, 2025

@Rocketknight1 CI checks errors are solved and take a look again.

Copy link
Member

@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, all of these look good. Thank you for the fixes!

@Rocketknight1 Rocketknight1 merged commit af9b2ea into huggingface:main Mar 10, 2025
8 checks passed
@threewebcode threewebcode deleted the develop branch March 10, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants