Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dtype bug #30518

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix dtype bug #30518

wants to merge 1 commit into from

Conversation

chujiezheng
Copy link

@chujiezheng chujiezheng commented Apr 27, 2024

It would raise error if we use the bfloat16 dtype.

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

It would raise error if we use the bfloat16 dtype.
@amyeroberts
Copy link
Collaborator

Hi @chujiezheng, thanks for opening a PR!

Could you share an example snippet which reproduces this error on main?

@chujiezheng
Copy link
Author

import torch
from transformers import pipeline

rm_pipe = pipeline(
    "sentiment-analysis",
    model="weqweasdas/RM-Mistral-7B",
    device_map='auto',
    torch_dtype=torch.bfloat16,
)
texts = ['hello']
outputs = rm_pipe(texts)

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chujiezheng Thanks for proving an example!

Could you also add a test which will fail on main but pass on this branch? Ideally, this test should be added to all pipelines to check that can accept bf16 inputs.

@chujiezheng
Copy link
Author

Sorry, I do not get it well. What tests should I do, e.g., with other pipelines?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants