Fix cache_position initialisation for generation with use_cache=False
#30485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gante
approved these changes
May 3, 2024
There was a problem hiding this comment.
LGTM, thank you for the fix 👍
@ArthurZucker tbh, when we have use_cache=False, we shouldn't even be creating or using cache_positions at all (as the name of the variable indicates, its purpose is cache-related). ATM, the only dependency is the causal mask creation function, which uses cache_positions as a proxy for the sequence length (i.e. we can easily rearrange the code to avoid using it when there is no cache :) )
ArthurZucker
approved these changes
May 7, 2024
|
Can you just rebase on main? 🤗 |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
nurlanov-zh
force-pushed
the
fix-cache-position-init
branch
from
7b9c0ba
to
e1b1c10
Compare
@ArthurZucker , done ✔️ |
|
Thanks 🤗 |
zucchini-nlp
pushed a commit
to zucchini-nlp/transformers
that referenced
this pull request
May 10, 2024
…lse` (huggingface#30485) * Fix cache_position init for generation * Update src/transformers/generation/utils.py Co-authored-by: Arthur <[email protected]> * Fix cache position update --------- Co-authored-by: Arthur <[email protected]>
itazap
pushed a commit
that referenced
this pull request
May 14, 2024
…lse` (#30485) * Fix cache_position init for generation * Update src/transformers/generation/utils.py Co-authored-by: Arthur <[email protected]> * Fix cache position update --------- Co-authored-by: Arthur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #30482
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@ArthurZucker @younesbelkada @gante