Skip to content

feat: improve llava next pooling for granite vision #3255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

drbh
Copy link
Collaborator

@drbh drbh commented Jun 4, 2025

This PR improve LlavaNextForConditionalGeneration to handle models that specify pooled vision_feature_layer.

more concretely the ibm-granite/granite-vision-3.2-2b model specifies

    "vision_feature_layer": [
        -24,
        -20,
        -12,
        -1
    ],

and requires that those layers are pooled. This change allows vision_feature_layer to be a list an iterates over the layers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant