Fix and test validate_tools_and_managed_agents#731
Merged
Conversation
Member
Author
|
The failing CI tests is unrelated: and will be fixed by: |
aymeric-roucher
approved these changes
Feb 22, 2025
| # Invalid case: tool name same as managed agent's tool name | ||
| ([MockTool("tool1")], [MockAgent("agent1", [MockTool("tool1")])], pytest.raises(ValueError)), | ||
| # Invalid case: duplicate managed agent name and managed agent tool name | ||
| ([], [MockAgent("tool1", [MockTool("tool1")])], pytest.raises(ValueError)), |
Collaborator
There was a problem hiding this comment.
Same as above, I'm not sure that this should raise an error.
Member
Author
|
You are right, @aymeric-roucher: those test should not raise error. I have reverted: and include the agent.name to be compared wit agent.tools and agent.managed_agents names, so that we fix issue: This PR also fixes: |
albertvillanova
changed the title
maxwellfet928
added a commit
to maxwellfet928/smolagents
that referenced
this pull request
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix and test
_validate_tools_and_managed_agents.Revert PR:
Fix #795.