Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix loading of vllm model from files #533

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Fix loading of vllm model from files #533

wants to merge 9 commits into from

Conversation

NathanHB
Copy link
Member

@NathanHB NathanHB commented Feb 4, 2025

No description provided.

@HuggingFaceDocBuilderDev
Copy link
Collaborator

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@NathanHB NathanHB requested a review from clefourrier February 4, 2025 14:07
clefourrier
clefourrier reviewed Feb 6, 2025
View reviewed changes
Copy link
Member

@clefourrier clefourrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaks the tests atm

@NathanHB
Copy link
Member Author

NathanHB commented Feb 6, 2025

it's weird, we have the same tests fails on lewis' PR I dont get why

@clefourrier
Copy link
Member

clefourrier commented Feb 6, 2025 •
edited
Loading

Most likely culprit imo: cb35bea (and the latex2sympy version change)

lewtun
lewtun reviewed Feb 6, 2025
View reviewed changes
Copy link
Member

@lewtun lewtun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice feature! Could you add some small doc on how to toggle the params (I know you have the YAML, but having it in the docs would be helpful)

Also, what sampling params are exposed? Is it everything in SamplingParams or just temperature and max_tokens?

@NathanHB
Copy link
Member Author

NathanHB commented Feb 6, 2025

Hi ! Sure I will add some docs.
Everything in sampling params is exposed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lewtun lewtun lewtun left review comments

@clefourrier clefourrier clefourrier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NathanHB @HuggingFaceDocBuilderDev @clefourrier @lewtun