Skip to content

Conversation

ryan-minato
Copy link
Contributor

finish #478

Copy link
Member

@NathanHB NathanHB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@NathanHB
Copy link
Member

NathanHB commented Jan 7, 2025

Hi ! You just need to fix the tests and this should be good :)

@ryan-minato
Copy link
Contributor Author

Hi ! You just need to fix the tests and this should be good :)

I forgot to import Literal, but I've just fixed it. The pre-commit checks have already passed on my machine.

@HuggingFaceDocBuilderDev
Copy link
Collaborator

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@clefourrier clefourrier merged commit be18ae5 into huggingface:main Jan 20, 2025
3 checks passed
@ryan-minato ryan-minato deleted the feat/asian-lang-translate-metic branch January 21, 2025 07:33
hynky1999 pushed a commit that referenced this pull request May 22, 2025
* feat: add asian language support to CorpusLevelTranslationMetric

* fix: ci
NathanHB pushed a commit that referenced this pull request Sep 19, 2025
* feat: add asian language support to CorpusLevelTranslationMetric

* fix: ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants