[gguf] Add types #562
Merged
[gguf] Add types #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mishig25
commented
Mar 19, 2024
Comment on lines
+4
to
+5
| export type { MetadataValue, Version, GGUFMetadata, GGUFTensorInfo, GGUFParseOutput } from "./types"; | ||
| export { GGUFValueType, GGMLQuantizationType } from "./types"; |
There was a problem hiding this comment.
is it a correct way to re-export ?
julien-c
reviewed
Mar 20, 2024
Comment on lines
+6
to
+29
| export enum GGMLQuantizationType { | ||
| F32 = 0, | ||
| F16 = 1, | ||
| Q4_0 = 2, | ||
| Q4_1 = 3, | ||
| Q5_0 = 6, | ||
| Q5_1 = 7, | ||
| Q8_0 = 8, | ||
| Q8_1 = 9, | ||
| Q2_K = 10, | ||
| Q3_K = 11, | ||
| Q4_K = 12, | ||
| Q5_K = 13, | ||
| Q6_K = 14, | ||
| Q8_K = 15, | ||
| IQ2_XXS = 16, | ||
| IQ2_XS = 17, | ||
| IQ3_XXS = 18, | ||
| IQ1_S = 19, | ||
| IQ4_NL = 20, | ||
| IQ3_S = 21, | ||
| IQ2_S = 22, | ||
| IQ4_XS = 23, | ||
| } |
There was a problem hiding this comment.
enums are not strictly speaking types as they expose objects in the runtime.
End of not super useful pedantic note haha. cc @coyotte508
julien-c
approved these changes
Mar 20, 2024
| export type RWKV = ModelBase<"rwkv"> & { "rwkv.architecture_version": number }; | ||
| export type LLM = TransformerLLM | RWKV; | ||
| export type Whisper = ModelBase<"encoder.whisper"> & ModelBase<"decoder.whisper">; | ||
| export type Model = (LLM | Whisper) & Partial<Tokenizer>; |
There was a problem hiding this comment.
very neat types (though they make my head hurt a bit, lol)
julien-c
reviewed
Mar 20, 2024
Comment on lines
+48
to
+57
| "llama", | ||
| "mpt", | ||
| "gptneox", | ||
| "gptj", | ||
| "gpt2", | ||
| "bloom", | ||
| "falcon", | ||
| "gemma", | ||
| "rwkv", | ||
| "whisper", |
There was a problem hiding this comment.
Suggested change
| "llama", | |
| "mpt", | |
| "gptneox", | |
| "gptj", | |
| "gpt2", | |
| "bloom", | |
| "falcon", | |
| "gemma", | |
| "rwkv", | |
| "whisper", | |
| "llama", | |
| "falcon", | |
| "baichuan", | |
| "gpt2", | |
| "gptj", | |
| "gptneox", | |
| "mpt", | |
| "starcoder", | |
| "persimmon", | |
| "refact", | |
| "bert", | |
| "nomic-bert", | |
| "bloom", | |
| "stablelm", | |
| "qwen", | |
| "qwen2", | |
| "phi2", | |
| "plamo", | |
| "codeshell", | |
| "orion", | |
| "internlm2", | |
| "minicpm", | |
| "gemma", | |
| "starcoder2", | |
| "mamba", |
There was a problem hiding this comment.
(optional, but it's the current list from the llama.cpp source of truth IIUC)
julien-c
approved these changes
Mar 20, 2024
This was referenced Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GGUF add types. Follow up to #540 (comment).
No any kind of validation, just types
cc: @biw also