-
Notifications
You must be signed in to change notification settings - Fork 463
Add fme to model libraries #1559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @oliverwm1 , thanks opening this PR! Content looks good to me with a small suggestion on the naming. Also, for this PR to work you'll have to tag the models in https://huggingface.co/collections/allenai/ace-67327d822f0f0d8e0e5e6ca4 with library_name: fme
. I opened https://huggingface.co/allenai/ACE-climSST/discussions/2 as a demo PR. Other models should be tagged the same way. Please let me know once that's done and we should be good to merge!
prettyLabel: "fme", | ||
repoName: "fme", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prettyLabel: "fme", | |
repoName: "fme", | |
prettyLabel: "Fuil Model Emulation", | |
repoName: "Fuil Model Emulation", |
Only a suggestion, based on https://ai2-climate-emulator.readthedocs.io/en/latest/. It feels more explicit than "fme". I'm fine with either solution as long as we put the same value in both prettyLabel
and repoName
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Wauplin, I'm taking over this PR for @oliverwm1 since he is on leave. Whatever name we choose here is also how each model in the collection should be tagged, and "Full Model Emulation" would work as a tag as well, correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey 🤗 fme
would remain tag to use in the modelcard metadata => library_name: fme
. The naming I suggest here ("Fuil Model Emulation"
) is how it will be displayed on the Hub. We usually go for a short, lowercase, no-spaces tag and then add a human-readable pretty name, hence my suggestion :)
Ok let's close this one and continue the discussion on #1628 then :) |
This is the library used for training and running Ai2 Climate Emulator: https://huggingface.co/collections/allenai/ace-67327d822f0f0d8e0e5e6ca4