Skip to content

Commit

Permalink
Pin ubuntu-22.04 for build_pr_documentation.yml (#531)
Browse files Browse the repository at this point in the history
* Revert "Add `--break-system-packages` to pip commands to fix doc uploads (#530)"

This reverts commit de0a1ef.

* Revert "pip install -U uv --break-system-packages (#529)"

This reverts commit f694f03.

* Revert "Use python virtual env for gh CI (#528)"

This reverts commit f71c7ba.

* build_pr_documentation ubuntu-22.04

* fix test

* pip install -U uv --break-system-packages for build_main_doc.yml
  • Loading branch information
mishig25 authored Oct 14, 2024
1 parent de0a1ef commit 080f84b
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 16 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/accelerate_doc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,11 @@ jobs:
cd accelerate
pip install .[dev]
cd ..
- name: Make documentation
run: |
cd doc-builder &&
doc-builder build accelerate ../accelerate/docs/source --build_dir ../build_dir --clean --html &&
cd ..
env:
NODE_OPTIONS: --max-old-space-size=6656
NODE_OPTIONS: --max-old-space-size=6656
14 changes: 2 additions & 12 deletions .github/workflows/build_pr_documentation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ on:

jobs:
build_pr_documentation:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
container:
${{ inputs.custom_container }}
env:
Expand All @@ -84,11 +84,6 @@ jobs:
node-version: '20'
cache-dependency-path: "kit/package-lock.json"

- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: '3.10'

- name: Export ROOT_APT_GET ('apt-get' or 'sudo apt-get')
# Use `sudo` only if running on the base runner.
# When using a container, `sudo` is not needed (and not installed)
Expand Down Expand Up @@ -146,15 +141,10 @@ jobs:
with:
toolchain: stable

- name: Create and activate virtual environment
run: |
python -m venv venv
source venv/bin/activate
# Use venv in both cases
- name: Install uv
run: |
pip install -U uv --break-system-packages
pip install -U uv
uv venv
- name: Setup environment
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/upload_pr_documentation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,9 @@ jobs:
shell: bash
id: setup-env
run: |
pip install black --break-system-packages
pip install black
cd doc-builder
pip install . --break-system-packages
pip install .
cd ..
echo "current_work_dir=$(pwd)" >> $GITHUB_OUTPUT
Expand Down

0 comments on commit 080f84b

Please sign in to comment.