Fix resolve_pattern for local symlinked files #7973
+57
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some fsspec versions report local symlinks as type='other' and may omit the 'islink' flag. This caused symlinked parquet files (common in HF cache layouts with blob storage) to be excluded from pattern matching. Changes: - Explicitly check os.path.islink() for local file protocol - Add regression test that forces the type='other' scenario Fixes huggingface#7084 Co-authored-by: Cursor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix globbing local symlinked parquet files when fsspec reports symlinks as
type='other'(common in HF cache layouts with blob storage).Some fsspec versions report local symlinks as
type='other'and may omit theislinkflag. This caused symlinked files to be excluded from pattern matching when usingload_datasetwith local file patterns.Changes
os.path.islink()for local file protocol inresolve_pattern()type='other'scenarioTest plan
test_resolve_pattern_locally_glob_includes_symlinked_filesto verify symlinks are includedtest_data_files.pypass (223 tests)Fixes #7084